[webkit-reviews] review granted: [Bug 60692] [SVG] Assertion failure by dragging text between input fields inside <foreignObject>s : [Attachment 94584] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 24 09:41:39 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has granted Leo Yang
<leo.yang at torchmobile.com.cn>'s request for review:
Bug 60692: [SVG] Assertion failure by dragging text between input fields inside
<foreignObject>s
https://bugs.webkit.org/show_bug.cgi?id=60692

Attachment 94584: Patch
https://bugs.webkit.org/attachment.cgi?id=94584&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94584&action=review

> LayoutTests/editing/pasteboard/drag-drop-input-in-svg.svg:14
> +(function runTest()
> +{

Is it really necessary to have a function?  I would have done:
if (window.layoutTestController) {
   ...
}


More information about the webkit-reviews mailing list