[webkit-reviews] review denied: [Bug 60377] [Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on Linux : [Attachment 94622] Fixing typos.

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Idrees <sidreesshah at hotmail.com>'s
request for review:
Bug 60377: [Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on
Linux
https://bugs.webkit.org/show_bug.cgi?id=60377

Attachment 94622: Fixing typos.
https://bugs.webkit.org/attachment.cgi?id=94622&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94622&action=review

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:2446
> -	   if (info.size > 1)
> +	   if (info.size > 1 && info.name.endsWith("[0]"))

Is "[0]" the only thing we should be stripping. What about "[1]"?
This looks like a testable change, why is there no new test in this patch?

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:-1448
> -    ASSERT(program);

This should be in a separate patch.