[webkit-reviews] review granted: [Bug 61063] TestFailures page shows testers that don't have any failing tests, which isn't useful : [Attachment 94605] Make TestFailures show how many tests are failing on each tester, and omit testers with no failures

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 61063: TestFailures page shows testers that don't have any failing tests,
which isn't useful
https://bugs.webkit.org/show_bug.cgi?id=61063

Attachment 94605: Make TestFailures show how many tests are failing on each
tester, and omit testers with no failures
https://bugs.webkit.org/attachment.cgi?id=94605&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94605&action=review

r=me

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builde
r.js:68
> +	   getResource(self.buildbot.baseURL + 'json/builders/' + self.name,
function(xhr) {

Nit: Seems like "function(xhr) {" should be indented at the same level as the
method below.

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builde
r.js:90
> +	   },
> +	   function(xhr) {
> +	       self._cache[cacheKey] = -1;
> +	       callback(self._cache[cacheKey]);
> +	   });

Nit: Is this code indented correctly?