[webkit-reviews] review requested: [Bug 59193] Web Inspector: Use different SourceFrame instances for ResourcesPanel and NetworkPanel : [Attachment 94609] Patch with fixes after review

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has asked  for review:
Bug 59193: Web Inspector: Use different SourceFrame instances for
ResourcesPanel and NetworkPanel
https://bugs.webkit.org/show_bug.cgi?id=59193

Attachment 94609: Patch with fixes after review
https://bugs.webkit.org/attachment.cgi?id=94609&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
(In reply to comment #13)
> (From update of attachment 94054 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=94054&action=review
> 
> > Source/WebCore/inspector/front-end/ResourceView.js:46
> > +WebInspector.ResourceView.isSourceViewableForResource = function(resource)

> 
> Maybe hasTextContent?
Done.

> > Source/WebCore/inspector/front-end/ResourceView.js:73
> > +	 WebInspector.SourceFrameDelegate.call(this);
> 
> SourceFrameDelegate is a scripts panel specific delegate used to invert
SourceFrame -> ScriptsPanel dependency. It's strange that you derive
ResourceSourceFrameDelegate from it. Could you implement TextViewerDelegate
interface instead?
As discussed, I have overridden these methods in SourceFrame descendants.