[webkit-reviews] review denied: [Bug 51586] CSSParser: m_implicitShorthand should probably be RAII : [Attachment 93751] [PATCH] levin's comments addressed

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 51586: CSSParser: m_implicitShorthand should probably be RAII
https://bugs.webkit.org/show_bug.cgi?id=51586

Attachment 93751: [PATCH] levin's comments addressed
https://bugs.webkit.org/attachment.cgi?id=93751&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93751&action=review

> Source/WebCore/css/CSSParser.cpp:100
> +    ImplicitScope(WebCore::CSSParser* parser, bool isImplicit)

bool isImplicit should be an enum (instead of a bool) because one can't tell at
the calling site what it means.

For example, when one sees
 ImplicitScope implicitScope(this, true);
It isn't clear what "true" means.