[webkit-reviews] review granted: [Bug 60254] Remove platform layering violation: TextRun stores RenderObjects for SVG Fonts support : [Attachment 94599] Patch v4
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 24 06:45:25 PDT 2011
Antti Koivisto <koivisto at iki.fi> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 60254: Remove platform layering violation: TextRun stores RenderObjects for
SVG Fonts support
https://bugs.webkit.org/show_bug.cgi?id=60254
Attachment 94599: Patch v4
https://bugs.webkit.org/attachment.cgi?id=94599&action=review
------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=94599&action=review
r=me
> Source/WebCore/rendering/svg/SVGTextRunRenderingContext.h:38
> +
> + RenderObject* context() const { return m_context; }
This could have some more specific name than "context", especially since the
class itself is called *Context.
More information about the webkit-reviews
mailing list