[webkit-reviews] review granted: [Bug 60827] [GTK] Implement GraphicsContextCairo::imageInterpolationQuality(). : [Attachment 94583] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 60827: [GTK] Implement GraphicsContextCairo::imageInterpolationQuality().
https://bugs.webkit.org/show_bug.cgi?id=60827

Attachment 94583: Patch
https://bugs.webkit.org/attachment.cgi?id=94583&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
Nice, r=me.

A little about this setting, for anyone who is interested:

The most common use case for GC's imageInterpolationQuality is indeed the
ImageQualityController which is a mechanism that ensures that we don't waste
time painting an image with high-quality scaling when it's likely to be
repainted very soon again.

For example, when the page is being scrolled, an image may be repainted over
and over (with a primitive drawing model) and WebCore then tells the GC to draw
it with low quality scaling until it sits in the same place for 0.5s
(cLowQualityTimeThreshold in RenderBoxModelObject.cpp.) It's also used when
animating images via JavaScript, e.g by dynamically altering the width/height
attributes.