[webkit-reviews] review requested: [Bug 32865] [Qt] QWebElement::attribute always returns empty result for input's values : [Attachment 94570] Patch refined according to last comment

[bugzilla-daemon at webkit.org]

wolfy <wolfram at ritsuka.org> has asked  for review:
Bug 32865: [Qt] QWebElement::attribute always returns empty result for input's
values
https://bugs.webkit.org/show_bug.cgi?id=32865

Attachment 94570: Patch refined according to last comment
https://bugs.webkit.org/attachment.cgi?id=94570&action=review

------- Additional Comments from wolfy <wolfram at ritsuka.org>
(In reply to comment #39)
> Invalid indentation.
Fixed.
 
> This is not indented correctly.
Fixed.
 
> > Source/WebKit/qt/ChangeLog:1
> > +2011-04-29  wolfy	<wolfram at ritsuka.org>
> 
> You should probably put your name in here.
I don't want to do that. 

> This, the title and url, usually goes above the description, not after.
Fixed.
 
> > Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp:1045
> > +	 // No initial value
> 
> You should have a period at the end of sentences. (This one and the other
comments).
Fixed. But I didn't see periods in any other comments in this file.


> I would think the correct value for inputElement.attribute("value") is empty
but not null.
> While a null string would be if there is no value attribute.
> 
> Kind of reverse from the comment for the text, I would expect value to be
null in this case, not empty.
Fixed.