[webkit-reviews] review granted: [Bug 61277] WebSocket: Add fail() to WebSocketChannel and its family : [Attachment 94411] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Yuta Kitamura
<yutak at chromium.org>'s request for review:
Bug 61277: WebSocket: Add fail() to WebSocketChannel and its family
https://bugs.webkit.org/show_bug.cgi?id=61277

Attachment 94411: Patch
https://bugs.webkit.org/attachment.cgi?id=94411&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94411&action=review

> Source/WebCore/websockets/ThreadableWebSocketChannel.h:56
> +    virtual void fail(const String& reason) = 0; // Log the reason text and
close the connection. Will call didClose().

nit: I feel such long comment should be moved to its own line.

> Source/WebCore/websockets/WebSocketChannel.h:62
> +	   virtual void fail(const String& reason); // Log the reason text and
close the connection. Will call didClose().
>	   virtual void disconnect(); // Will suppress didClose().

ThreadableWebSocketChannel has these comments.	So we may remove them here.

> Source/WebCore/websockets/WorkerThreadableWebSocketChannel.cpp:385
> +    m_loaderProxy.postTaskToLoader(
> +	  
createCallbackTask(&WorkerThreadableWebSocketChannel::mainThreadFail,
AllowCrossThreadAccess(m_peer), reason));

No need to break the line.