[webkit-reviews] review denied: [Bug 61273] Wrap input color in feature flag : [Attachment 94547] fixed mistake

Mon May 23 20:50:06 PDT 2011

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 61273: Wrap input color in feature flag
https://bugs.webkit.org/show_bug.cgi?id=61273

Attachment 94547: fixed mistake
https://bugs.webkit.org/attachment.cgi?id=94547&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94547&action=review

> LayoutTests/ChangeLog:20
> +	   * fast/forms/ValidityState-typeMismatch-color-expected.txt: Removed.

> +	   * fast/forms/ValidityState-typeMismatch-color.html: Removed.
> +	   * fast/forms/color/input-value-sanitization-color-expected.txt:
Added.
> +	   * fast/forms/color/input-value-sanitization-color.html: Added. Tests

> +	   sanitization algorithm for input type=color.
> +	   * fast/forms/color/input-value-sanitization-color.js: Added.
> +	   * fast/forms/input-widths-expected.txt: 
> +	   * fast/forms/input-widths.html: Removed type=color because it
> +	   is no loger a text input type.
> +	   * fast/forms/script-tests/ValidityState-typeMismatch-color.js:
Removed.
> +	   * platform/gtk/Skipped: Skip fast/forms/color.
> +	   * platform/qt/Skipped: Skip fast/forms/color.
> +	   * platform/win/Skipped: Skip fast/forms/color.

This file list is out-of-sync.

> LayoutTests/fast/forms/ValidityState-patternMismatch-unsupported.html:-13
> -<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
> -<html>
> -<head>
> -<link rel="stylesheet" href="../../fast/js/resources/js-test-style.css">
> -<script src="../../fast/js/resources/js-test-pre.js"></script>
> -</head>
> -<body>
> -<p id="description"></p>
> -<div id="console"></div>
> -<script
src="script-tests/ValidityState-patternMismatch-unsupported.js"></script>
> -<script src="../../fast/js/resources/js-test-post.js"></script>
> -</body>
> -</html>

Please don't remove it.
We should change the type=color usage to another type which doesn't support the
pattern attribute.