[webkit-reviews] review granted: [Bug 60077] [chromium] Properly handle huge initial dimensions for 2d canvas when accelerated 2d canvas is enabled : [Attachment 94532] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 23 18:45:57 PDT 2011
Kenneth Russell <kbr at google.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 60077: [chromium] Properly handle huge initial dimensions for 2d canvas
when accelerated 2d canvas is enabled
https://bugs.webkit.org/show_bug.cgi?id=60077
Attachment 94532: Patch
https://bugs.webkit.org/attachment.cgi?id=94532&action=review
------- Additional Comments from Kenneth Russell <kbr at google.com>
Looks fine. I do wonder whether we should attempt to allocate the color buffer
(generateColorTexture) at all if the size is too large, but it should fail with
an OpenGL error and the cleanup code should work.
More information about the webkit-reviews
mailing list