[webkit-reviews] review denied: [Bug 61273] Wrap input color in feature flag : [Attachment 94404] Disable input color. Add INPUT_COLOR feature flag. Implement input color sanitizer.

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 61273: Wrap input color in feature flag
https://bugs.webkit.org/show_bug.cgi?id=61273

Attachment 94404: Disable input color. Add INPUT_COLOR feature flag. Implement
input color sanitizer.
https://bugs.webkit.org/attachment.cgi?id=94404&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94404&action=review

r- because of Chromium Linux test failures.

> LayoutTests/fast/forms/color/input-value-sanitization-color.html:10
> +<script src="input-value-sanitization-color.js"></script>

You don't need to separate the JS code to another file.  Please embed it here.

> Source/WebCore/ChangeLog:7
> +	   Disable input color. Add INPUT_COLOR feature flag. Implement input
color sanitizer.
> +	   https://bugs.webkit.org/show_bug.cgi?id=29358
> +

You need more words for "Disable input color".	e.g. Disable textfield
implementation of <input type=color>.

nit: you can split the patch into three:
 - Introduce INPUT_COLOR flag
 - Disabled textfield implementation
 - Implement value sanitization
You may proceed this patch without splitting because I'm very familiar with the
code around there.  But smaller patch is better in general.