[webkit-reviews] review granted: [Bug 61311] REGRESSION (86992): World leak when all windows closed : [Attachment 94508] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 61311: REGRESSION (86992): World leak when all windows closed
https://bugs.webkit.org/show_bug.cgi?id=61311

Attachment 94508: Patch
https://bugs.webkit.org/attachment.cgi?id=94508&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=94508&action=review

> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:-141
> -    [webView retain];
> -    [_webView release];

I still don’t think it was best to remove these. A retain cycle is not
intrinsically incorrect, as long as something breaks the cycle.