[webkit-reviews] review denied: [Bug 60377] [Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on Linux : [Attachment 94081] More description about the issue in changelog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 23 16:05:42 PDT 2011


Alexis Menard <alexis.menard at openbossa.org> has denied Idrees
<sidreesshah at hotmail.com>'s request for review:
Bug 60377: [Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on
Linux
https://bugs.webkit.org/show_bug.cgi?id=60377

Attachment 94081: More description about the issue in changelog
https://bugs.webkit.org/attachment.cgi?id=94081&action=review

------- Additional Comments from Alexis Menard <alexis.menard at openbossa.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94081&action=review

> Source/WebCore/ChangeLog:10
> +	   for an array of active uniform, we can receive just a name without 

Uppercase for the first letter, it's a sentence.

> Source/WebCore/ChangeLog:11
> +	   array braces. Currently i donot see any [0] in the active uniform
arrays name 

missing space.

> Source/WebCore/ChangeLog:12
> +	   and as a result we were trucating the the actual name of the active
uniforms. 

typo again.


More information about the webkit-reviews mailing list