[webkit-reviews] review denied: [Bug 55877] [Qt][WK2][Symbian] CoreIPC implementation for Symbian OS : [Attachment 94254] Patch

[bugzilla-daemon at webkit.org]

Alexis Menard <alexis.menard at openbossa.org> has denied Siddharth Mathur
<siddharth.mathur at nokia.com>'s request for review:
Bug 55877: [Qt][WK2][Symbian] CoreIPC implementation for Symbian OS
https://bugs.webkit.org/show_bug.cgi?id=55877

Attachment 94254: Patch
https://bugs.webkit.org/attachment.cgi?id=94254&action=review

------- Additional Comments from Alexis Menard <alexis.menard at openbossa.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94254&action=review

> Source/WebKit2/WebProcess/qt/WebProcessMainQt.cpp:135
> +#if defined(Q_OS_SYMBIAN)

Why defined(Q_OS_SYMBIAN) and below in the same file you use #if OS(SYMBIAN)?

> Tools/Makefile:-1
> -MODULES = DumpRenderTree WebKitTestRunner MiniBrowser
../Source/ThirdParty/gtest/xcode TestWebKitAPI

What is that file?

> Tools/Makefile:22
> +INCPATH	 = 
-I"/home/simathur/testQtSDK/Symbian/SDKs/Symbian3Qt472/include/QtCore" 
-I"/home/simathur/testQtSDK/Symbian/SDKs/Symbian3Qt472/include/QtGui" 
-I"/home/simathur/testQtSDK/Symbian/SDKs/Symbian3Qt472/include" 
-I"/home/simathur/testQtSDK/Symbian/SDKs/Symbian3Qt472/include/QtSensors" 
-I"/home/simathur/testQtSDK/Symbian/SDKs/Symbian3Qt472/mkspecs/common/symbian" 
-I"/home/simathur/testQtSDK/Symbian/SDKs/Symbian3Qt472/epoc32/include" 
-I"/home/simathur/testQtSDK/Symbian/SDKs/Symbian3Qt472/epoc32/include/stdapis" 
-I"/home/simathur/testQtSDK/Symbian/SDKs/Symbian3Qt472/epoc32/include/stdapis/s
ys"  -I"/home/simathur/testQtSDK/Symbian/SDKs/Symbian3Qt472/epoc32/include/mw" 
-I"/home/simathur/testQtSDK/Symbian/SDKs/Symbian3Qt472/epoc32/include/platform/
mw" 
-I"/home/simathur/testQtSDK/Symbian/SDKs/Symbian3Qt472/epoc32/include/platform"

-I"/home/simathur/testQtSDK/Symbian/SDKs/Symbian3Qt472/epoc32/include/platform/
loc" 
-I"/home/simathur/testQtSDK/Symbian/SDKs/Symbian3Qt472/epoc32/include/platform/
mw/loc" 
-I"/home/simathur/testQtSDK/Symbian/SDKs/Symbian3Qt472/epoc32/include/platform/
loc/sc" 
-I"/home/simathur/testQtSDK/Symbian/SDKs/Symbian3Qt472/epoc32/include/platform/
mw/loc/sc"  -I"/QtMobility"  -I"/QtSensors" 
-I"/home/simathur/testQtSDK/Symbian/SDKs/Symbian3Qt472/epoc32/include/stdapis/s
tlportv5"  -I"/home/simathur/WebKit/Tools" 

Seems totally wrong.