[webkit-reviews] review granted: [Bug 61298] VO doesn't work with HTML5 range (slider) input @step attribute : [Attachment 94465] patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 61298: VO doesn't work with HTML5 range (slider) input @step attribute
https://bugs.webkit.org/show_bug.cgi?id=61298

Attachment 94465: patch
https://bugs.webkit.org/attachment.cgi?id=94465&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94465&action=review

r=me, but consider making the test try to go below the minimum value of the
slider as well.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:890
> +	   changeValueByPercent((increase) ? 5 : -5);

Nit: Don't need parenthesis around (increase) here.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2224
> +    value += (increase) ? step : -step;

Nit: Don't need parenthesis around (increase) here.

> LayoutTests/platform/mac/accessibility/range-alter-by-step.html:39
> +	     obj.increment();
> +	     shouldBe("obj.intValue", "100");

Nice job of testing going over the maximum value!

I'd really like to see it try to go below the minimum value as well in this
test.