[webkit-reviews] review granted: [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists : [Attachment 88543] Add export macros to wtf/text/WTFString.h

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 23 15:13:55 PDT 2011


Eric Seidel <eric at webkit.org> has granted Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 27551: Make it possible to build JavaScriptCore as shared library without
symbol lists
https://bugs.webkit.org/show_bug.cgi?id=27551

Attachment 88543: Add export macros to wtf/text/WTFString.h
https://bugs.webkit.org/attachment.cgi?id=88543&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Since WTF_EXPORT_PRIVATE has already been approved, the idea has been OK'd. 
Looking at the implementation details of thsi patch, nothing seems awry.  So
OK.  rs=me.


More information about the webkit-reviews mailing list