[webkit-reviews] review denied: [Bug 57859] Add implementations of JavaInstance, JavaClass, JavaField and JavaMethod that simply proxy calls to a listener. : [Attachment 88402] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 23 15:05:08 PDT 2011


Eric Seidel <eric at webkit.org> has denied Steve Block <steveblock at google.com>'s
request for review:
Bug 57859: Add implementations of JavaInstance, JavaClass, JavaField and
JavaMethod that simply proxy calls to a listener.
https://bugs.webkit.org/show_bug.cgi?id=57859

Attachment 88402: Patch
https://bugs.webkit.org/attachment.cgi?id=88402&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This hasn't been touched in over 3 weeks.  Looks like there are still concerns
above.	Marking r-.

I would love it if someone would go through the exising JNI code and give it a
bath... Our second-most common cause of flaky tests is something to do with
liveconnect objects toString implementations being racy or something...


More information about the webkit-reviews mailing list