[webkit-reviews] review denied: [Bug 57685] AX: VoiceOver cannot use AXTextMarker calls when user-select:none : [Attachment 87948] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 23 14:58:24 PDT 2011


Eric Seidel <eric at webkit.org> has denied chris fleizach <cfleizach at apple.com>'s
request for review:
Bug 57685: AX: VoiceOver cannot use AXTextMarker calls when user-select:none
https://bugs.webkit.org/show_bug.cgi?id=57685

Attachment 87948: Patch
https://bugs.webkit.org/attachment.cgi?id=87948&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87948&action=review

> Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm:2544
> +    Position::setUserSelectNoneIgnored(true);

This should be a RIIA instead, and then this is a 3 line patch instead of 300.
:)


More information about the webkit-reviews mailing list