[webkit-reviews] review canceled: [Bug 61092] [Qt] Fix build after 79407 : [Attachment 94094] Patch to fix the build issue.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 23 14:41:32 PDT 2011
Alexis Menard <alexis.menard at openbossa.org> has canceled Enrico Ros
<eros at codeaurora.org>'s request for review:
Bug 61092: [Qt] Fix build after 79407
https://bugs.webkit.org/show_bug.cgi?id=61092
Attachment 94094: Patch to fix the build issue.
https://bugs.webkit.org/attachment.cgi?id=94094&action=review
------- Additional Comments from Alexis Menard <alexis.menard at openbossa.org>
It's a gentoo issue, they remove the headers generated by Qt on Linux.
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/x11-libs/qt-gui/qt-gui-
4.7.3.ebuild?view=markup
For sure we could fix the compilation, but with the features combination being
exponential we could easily fall into a trap like that (not necessarily because
of Mac related stuff). I'd say that we should fix the code and also ask them to
remove that kind of hack (couple of kbs on drive is no big deal nowadays).
More information about the webkit-reviews
mailing list