[webkit-reviews] review granted: [Bug 59753] Chromium Mac: Fork ScrollAnimatorMac to ScrollAnimatorChromiumMac for overlay scrollbar support : [Attachment 94473] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Sailesh Agrawal
<sail at chromium.org>'s request for review:
Bug 59753: Chromium Mac: Fork ScrollAnimatorMac to ScrollAnimatorChromiumMac
for overlay scrollbar support
https://bugs.webkit.org/show_bug.cgi?id=59753

Attachment 94473: Patch
https://bugs.webkit.org/attachment.cgi?id=94473&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94473&action=review

Seems OK

> Source/WebCore/platform/chromium/ScrollAnimatorChromiumMac.h:55
> +    ScrollAnimatorChromiumMac(ScrollableArea*);

should be explicit

> Source/WebCore/platform/graphics/IntPoint.h:40
> +#if PLATFORM(MAC) || (PLATFORM(CHROMIUM) && OS(DARWIN))

should this just be #if OS(DARWIN)?

> Source/WebCore/platform/graphics/IntPoint.h:122
> +#if (PLATFORM(MAC) || (PLATFORM(CHROMIUM) && OS(DARWIN))) &&
!defined(NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES)

should this just be #if OS(DARWIN) &&
!defined(NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES) ?