[webkit-reviews] review denied: [Bug 61097] Implement HTML5 location resolveURL : [Attachment 94241] Patch: Use KURL::string so that the return URL is not decoded

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 23 12:02:39 PDT 2011


Alexey Proskuryakov <ap at webkit.org> has denied Erik Arvidsson
<arv at chromium.org>'s request for review:
Bug 61097: Implement HTML5 location resolveURL
https://bugs.webkit.org/show_bug.cgi?id=61097

Attachment 94241: Patch: Use KURL::string so that the return URL is not decoded
https://bugs.webkit.org/attachment.cgi?id=94241&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r- to get this out of review queue, since some more work is still needed.

> Is resolveURL expected to preserve credentials from main document's URL

My thinking is that probably not. We shouldn't disclose user credentials to a
3rd party server.


More information about the webkit-reviews mailing list