[webkit-reviews] review denied: [Bug 47815] First-letter style is applied to the letters that were once first but not any more due to style change : [Attachment 78635] Post Source/WebCore move

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Yuzo Fujishima <yuzo at google.com>'s
request for review:
Bug 47815: First-letter style is applied to the letters that were once first
but not any more due to style change
https://bugs.webkit.org/show_bug.cgi?id=47815

Attachment 78635: Post Source/WebCore move
https://bugs.webkit.org/attachment.cgi?id=78635&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78635&action=review

> Source/WebCore/rendering/RenderBlock.cpp:5122
> +    RenderText* newText = new (renderArena())
RenderText(remainingTextFragment->node() ? remainingTextFragment->node() :
remainingTextFragment->document(), remainingTextFragment->fullOriginalText());

Oh please.  There must be a RenderTextFragment method to create this?

> Source/WebCore/rendering/RenderBlock.cpp:5123
> +    newText->setStyle(remainingTextFragment->style());

And this.

> Source/WebCore/rendering/RenderBlock.cpp:5128
> +    view()->disableLayoutState();

Don't we have RIIA to do this eanble/disable?

> Source/WebCore/rendering/RenderBlock.cpp:5255
> +    removeStaleFirstLetterForFirstLetterBlock(firstLetterBlock);

What's the runtime effect of adding this child-walk here?

> Source/WebCore/rendering/RenderBlock.cpp:5547
> +	   m_rareData = new RenderBlockRareData(this);

Is this OK with the new safe OwnPtrs?