[webkit-reviews] review granted: [Bug 61155] [fileapi] Add a File::createWithName method to avoid obfuscated filename leakage from FileEntry.file() method : [Attachment 94438] Update comment

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 23 10:43:14 PDT 2011


Jian Li <jianli at chromium.org> has granted Adam Klein <adamk at chromium.org>'s
request for review:
Bug 61155: [fileapi] Add a File::createWithName method to avoid obfuscated
filename leakage from FileEntry.file() method
https://bugs.webkit.org/show_bug.cgi?id=61155

Attachment 94438: Update comment
https://bugs.webkit.org/attachment.cgi?id=94438&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
Looks good except one minor comment. Please fix it before you land the patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=94438&action=review

> Source/WebCore/ChangeLog:13
> +	   (WebCore::DOMFileSystem::createFile): Updated to call
createWithName()

Please end the sentence with period and do the same thing for other comments.


More information about the webkit-reviews mailing list