[webkit-reviews] review denied: [Bug 58531] Handling invalid colors in SVG : [Attachment 90334] Draft patch third edition

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Oliver Varga
<Varga.Oliver at stud.u-szeged.hu>'s request for review:
Bug 58531: Handling invalid colors in SVG
https://bugs.webkit.org/show_bug.cgi?id=58531

Attachment 90334: Draft patch third edition
https://bugs.webkit.org/attachment.cgi?id=90334&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90334&action=review

Almost there, though you did not add a new test or upload existing test
changes, this looks suspicious, so r-.

> Source/WebCore/rendering/svg/RenderSVGResource.cpp:92
> +	       const SVGRenderStyle* parentSvgStyle =
object->parent()->style()->svgStyle();

To be on the safe side:
if (!object->parent() || !object->parent()->stye())
    return 0;
const SVGRenderStyle* parentSVGStyle = object->parent()->stye()->svgStye();
...

> Source/WebCore/rendering/svg/RenderSVGResource.cpp:105
> +	       const SVGRenderStyle* parentSvgStyle =
object->parent()->style()->svgStyle();

Same safety guard should be added here.

> Source/WebCore/rendering/svg/RenderSVGResource.cpp:118
> +	       const SVGRenderStyle* parentSvgStyle =
object->parent()->style()->svgStyle();

Ditto.

And please name it parentSVGStyle everywhere.