[webkit-reviews] review requested: [Bug 61192] Web Inspector: do not issue frontendReused for reload or navigate. : [Attachment 94389] patch

[bugzilla-daemon at webkit.org]

Andrey Kosyakov <caseq at chromium.org> has asked	for review:
Bug 61192: Web Inspector: do not issue frontendReused for reload or navigate.
https://bugs.webkit.org/show_bug.cgi?id=61192

Attachment 94389: patch
https://bugs.webkit.org/attachment.cgi?id=94389&action=review

------- Additional Comments from Andrey Kosyakov <caseq at chromium.org>
The way we remove old frames and preserve the main frame upon navigation is
somewhat unfortunate, so let's at least try to keep it on the model level,
rather than have similar logic proliferate to the higher-level ResourcePanel.
We already have notifications going from model to panel upon resource changes,
so it shouldn't be necessary to have a separate logic to reset it upon
navigation (unless for performance reasons, which, I think, are not really an
issue here). Here's my shot at fixing this -- mostly similar, but remove
obsolete frames one-by-one via "usual" means (_frameDetached).

To Pavel: I couldn't reproduce the bug you were observing with id collision of
old and new main frames in different renderers with my approach. OTOH, I don't
see why there should be such a bug, given that we seem to properly replace old
frames with new ones in case of id collision. May be I'm missing something...
:)