[webkit-reviews] review granted: [Bug 60185] [Cairo] Move the global alpha property from GraphicsContext to PlatformContextCairo : [Attachment 92321] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 60185: [Cairo] Move the global alpha property from GraphicsContext to
PlatformContextCairo
https://bugs.webkit.org/show_bug.cgi?id=60185

Attachment 92321: Patch
https://bugs.webkit.org/attachment.cgi?id=92321&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92321&action=review

r=me.

> Source/WebCore/platform/graphics/cairo/PlatformContextCairo.cpp:3
> + * Copyright (c) 2008, Google Inc. All rights reserved.

Why did you add googles copy right here?

> Source/WebCore/platform/graphics/cairo/PlatformContextCairo.cpp:143
> +float PlatformContextCairo::globalAlpha() const
> +{
> +    return m_state->m_globalAlpha;
> +}
> +
> +void PlatformContextCairo::setGlobalAlpha(float globalAlpha)
> +{
> +    m_state->m_globalAlpha = globalAlpha;
> +}

Is this common style for Gtk port? These one-liners can be moved to the headers
IMHO. But I'm fine if it is the Gtk way to do it.