[webkit-reviews] review granted: [Bug 61255] [Windows] Initial Cookie Accept Policy not set on Deserialized Storage Session : [Attachment 94357] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jessie Berlin <jberlin at webkit.org>'s
request for review:
Bug 61255: [Windows] Initial Cookie Accept Policy not set on Deserialized
Storage Session
https://bugs.webkit.org/show_bug.cgi?id=61255

Attachment 94357: Patch
https://bugs.webkit.org/attachment.cgi?id=94357&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=94357&action=review

> Source/WebKit2/WebProcess/win/WebProcessWin.cpp:144
> +   
WebCookieManager::shared().setHTTPCookieAcceptPolicy(parameters.initialHTTPCook
ieAcceptPolicy);

Moving this one line up seems like the bug fix. The other changes seem OK, but
I don’t see why they have to go along with this bug fix in the same patch. They
could be done separately before or after.

> Source/WebKit2/WebProcess/win/WebProcessWin.cpp:147
> +    // By using the default storage session that came from the UI Process,
the Web Process
> +    // automatically use the same the URL Cache as UI Process.

I suggest not capitalizing terms such as “web process”. Also, the second line
should read:

    // automatically uses the same URL cache as the UI process.