[webkit-reviews] review granted: [Bug 61231] Move EventQueue's Document-specific methods to a subclass : [Attachment 94320] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun May 22 18:04:17 PDT 2011
David Levin <levin at chromium.org> has granted David Grogan
<dgrogan at chromium.org>'s request for review:
Bug 61231: Move EventQueue's Document-specific methods to a subclass
https://bugs.webkit.org/show_bug.cgi?id=61231
Attachment 94320: Patch
https://bugs.webkit.org/attachment.cgi?id=94320&action=review
------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94320&action=review
> Source/WebCore/dom/EventQueue.cpp:64
> + eventTarget->toDOMWindow()->dispatchEvent(event, /*
PassRefPtr<EventTarget> */ 0);
Instead of putting in this comment and using an implicit conversion, just put
in PassRefPtr<EventTarget>(). (We'll likely want to remove the implicit
constructor anyway eventually like we did for OwnPtr.)
More information about the webkit-reviews
mailing list