[webkit-reviews] review denied: [Bug 61248] Replace script_path with script_shell_command : [Attachment 94344] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun May 22 09:20:51 PDT 2011
Adam Barth <abarth at webkit.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 61248: Replace script_path with script_shell_command
https://bugs.webkit.org/show_bug.cgi?id=61248
Attachment 94344: Patch
https://bugs.webkit.org/attachment.cgi?id=94344&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94344&action=review
> Tools/Scripts/webkitpy/common/checkout/scm/scm.py:94
> + if sys.platform == 'win32':
This file shouldn't depend on sys.platform. We're missing some sort of proper
abstraction.
More information about the webkit-reviews
mailing list