[webkit-reviews] review granted: [Bug 60897] [Qt] Implement toImageData() in QtWebKit Bridge : [Attachment 94330] implement toImageData() in Qt bridge

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 22 07:29:10 PDT 2011


Benjamin Poulain <benjamin at webkit.org> has granted Andrew Wason
<rectalogic at rectalogic.com>'s request for review:
Bug 60897: [Qt] Implement toImageData() in QtWebKit Bridge
https://bugs.webkit.org/show_bug.cgi?id=60897

Attachment 94330: implement toImageData() in Qt bridge 
https://bugs.webkit.org/attachment.cgi?id=94330&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94330&action=review

> Source/WebCore/bridge/qt/qt_pixmapruntime.cpp:100
> +    void copyPixels(QImage image, int width, int height, unsigned char*
destPixels)

const QImage &image.
By convention, we pass non-basic types as const reference.


More information about the webkit-reviews mailing list