[webkit-reviews] review requested: [Bug 60897] [Qt] Implement toImageData() in QtWebKit Bridge : [Attachment 94330] implement toImageData() in Qt bridge

[bugzilla-daemon at webkit.org]

Andrew Wason <rectalogic at rectalogic.com> has asked  for review:
Bug 60897: [Qt] Implement toImageData() in QtWebKit Bridge
https://bugs.webkit.org/show_bug.cgi?id=60897

Attachment 94330: implement toImageData() in Qt bridge 
https://bugs.webkit.org/attachment.cgi?id=94330&action=review

------- Additional Comments from Andrew Wason <rectalogic at rectalogic.com>
(In reply to comment #9)
> (From update of attachment 94090 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=94090&action=review
> 
> I was gonna r+, cq-, but I just noticed the doc is missing.
> Please update the documentation since this is a public API.

Added docs.

> > Source/WebCore/bridge/qt/qt_pixmapruntime.cpp:28
> > +#include "JSImageData.h"
> 
> We need that one?

It's needed for the declaration of WebCore::toJS(..., WebCore::ImageData*)

> 
> > Source/WebKit/qt/tests/hybridPixmap/test.html:23
> > +			     myWidget.compare(data[i  ], 0xaa); // R
> 
> No space after the i, No need to align the columns in the source.
> 
> > Source/WebKit/qt/tests/hybridPixmap/widget.h:48
> > +	 Q_INVOKABLE QImage abcImage(int format);
> 
> Why not put this as a public slot like the others?

OK, fixed both those.