[webkit-reviews] review granted: [Bug 61238] Share more code in PathTraversalState : [Attachment 94322] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 61238: Share more code in PathTraversalState
https://bugs.webkit.org/show_bug.cgi?id=61238

Attachment 94322: Patch
https://bugs.webkit.org/attachment.cgi?id=94322&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94322&action=review

Looks good, r=me.

> Source/WebCore/platform/graphics/PathTraversalState.cpp:209
> +    if (m_action == TraversalSegmentAtLength
> +	   && m_totalLength >= m_desiredLength)

No need to wrap the line here, eh?

> Source/WebCore/platform/graphics/PathTraversalState.cpp:214
> +    if ((m_action == TraversalPointAtLength
> +	   || m_action == TraversalNormalAngleAtLength)
> +	   && m_totalLength >= m_desiredLength) {

Ditto?

> Source/WebCore/platform/graphics/PathTraversalState.h:50
> +    void finalizeSegmentCalculation();

How about "processSegment" ?