[webkit-reviews] review granted: [Bug 61226] AudioBufferSourceNode noteOff() method must respect scheduling time : [Attachment 94296] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 20 17:59:13 PDT 2011


Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 61226: AudioBufferSourceNode noteOff() method must respect scheduling time
https://bugs.webkit.org/show_bug.cgi?id=61226

Attachment 94296: Patch
https://bugs.webkit.org/attachment.cgi?id=94296&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=94296&action=review

Looks fine. One comment about testing.

> Source/WebCore/ChangeLog:8
> +	   No new tests since audio API is not yet implemented.

Now that you have a mechanism for rendering to a buffer, would it make sense to
start writing layout tests?


More information about the webkit-reviews mailing list