[webkit-reviews] review granted: [Bug 19479] Special characters can be inserted in text field having reached maxlength : [Attachment 94282] proposed fix

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 19479: Special characters can be inserted in text field having reached
maxlength
https://bugs.webkit.org/show_bug.cgi?id=19479

Attachment 94282: proposed fix
https://bugs.webkit.org/attachment.cgi?id=94282&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94282&action=review

> LayoutTests/fast/forms/script-tests/input-number-commit-valid-only.js:22
>  document.execCommand('SelectAll', false, null);
>  document.execCommand('InsertText', false, '');
>  input.blur();
> -shouldBe('input.value', '"512"');
> +shouldBe('input.value', '""');

Oh, it's right.  An empty string is valid string for type=number.