[webkit-reviews] review granted: [Bug 61215] Default min DOM Timer interval is not set soon enough for first page to pick it up in WK2 : [Attachment 94267] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Matthew Delaney
<mdelaney at apple.com>'s request for review:
Bug 61215: Default min DOM Timer interval is not set soon enough for first page
to pick it up in WK2
https://bugs.webkit.org/show_bug.cgi?id=61215

Attachment 94267: Patch
https://bugs.webkit.org/attachment.cgi?id=94267&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=94267&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:210
> +    Settings::setDefaultMinDOMTimerInterval(0.004);

Moving this early seems good, but it’s a bit strange to tuck this in between
setting up the page clients and calling new Page, since the pageClients
structure is really just an argument to the Page constructor. I suggest calling
this even before the definition of the pageClients local variable, right after
the assert.