[webkit-reviews] review granted: [Bug 59577] if both border-radius and box-shadow applied, shadow is not fully visible : [Attachment 94155] Proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 20 11:03:31 PDT 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Kulanthaivel
Palanichamy <kulanthaivel at codeaurora.org>'s request for review:
Bug 59577: if both border-radius and box-shadow applied, shadow is not fully
visible
https://bugs.webkit.org/show_bug.cgi?id=59577

Attachment 94155: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=94155&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=94155&action=review

> Source/WebCore/platform/graphics/RoundedIntRect.cpp:81
> +    float factor = 0;

No need to initialize this here. You should also move this line to just above
the if () test below.


More information about the webkit-reviews mailing list