[webkit-reviews] review denied: [Bug 61011] [Refactoring] attach() following detach() should be replaced with Node::forceReattach() : [Attachment 94184] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied MORITA Hajime
<morrita at google.com>'s request for review:
Bug 61011: [Refactoring] attach() following detach() should be replaced with
Node::forceReattach()
https://bugs.webkit.org/show_bug.cgi?id=61011

Attachment 94184: Patch
https://bugs.webkit.org/attachment.cgi?id=94184&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94184&action=review

Thank you for taking on this!

> Source/WebCore/ChangeLog:9
> +	   - Replaced detach() following attach() with reattach()

Great name!

> Source/WebCore/dom/CharacterData.cpp:185
> +	   reattach();

This will never hit unless the node is already attached, so the value of
ReattachType is irrelevant here.

> Source/WebCore/dom/Node.h:454
> +    void reattach(ReattachType = ReattachIfAttached);

Looking at the callsites, I think ReattachAlways should be the default.

> Source/WebCore/dom/Node.h:746
> +    if (!attached()) {
> +	   if (type == ReattachAlways)
> +	       attach();

This seems wrong. Why are we attempting to attach here?