[webkit-reviews] review granted: [Bug 56649] [Qt][V8] Use qtscript-staging's shipped version of V8 when building with --v8 : [Attachment 94060] proposed patch v2.1

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Peter Varga
<pvarga at webkit.org>'s request for review:
Bug 56649: [Qt][V8] Use qtscript-staging's shipped version of V8 when building
with --v8
https://bugs.webkit.org/show_bug.cgi?id=56649

Attachment 94060: proposed patch v2.1
https://bugs.webkit.org/attachment.cgi?id=94060&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94060&action=review

The patch in general looks good, r=me. I think the FIXME comment should be
fixed though before landing (hence cq-).

>> Source/WebCore/bindings/v8/ScriptController.cpp:313
>> +
> 
> Is this because of Qt's copy of v8 being outdated?

Please replace this comment with a comment explaining why this code is
currently disabled for PLATFORM(QT)
and a link to a new bug in bugs.webkit.org that tracks fixing this once the v8
copy in Qt is updated.