[webkit-reviews] review granted: [Bug 61171] Apply the ParallelJobs support to FEConvolveMatrix : [Attachment 94185] Apply the ParallelJobs support to FEConvolveMatrix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 20 01:27:10 PDT 2011


Nikolas Zimmermann <zimmermann at kde.org> has granted Andras Piroska
<Piroska.Andras at stud.u-szeged.hu>'s request for review:
Bug 61171: Apply the ParallelJobs support to FEConvolveMatrix
https://bugs.webkit.org/show_bug.cgi?id=61171

Attachment 94185: Apply the ParallelJobs support to FEConvolveMatrix
https://bugs.webkit.org/attachment.cgi?id=94185&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94185&action=review

Looks great, r=me.

> Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp:258
> +    for (int y = yEnd + 1; y>yStart; --y) {
>	   for (int x = clipRight + 1; x > 0; --x) {

Style: y > yStart, please.


More information about the webkit-reviews mailing list