[webkit-reviews] review granted: [Bug 60869] Convert json_results_generator.py to output version 4 JSON. : [Attachment 94170] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Alice Boxhall
<aboxhall at chromium.org>'s request for review:
Bug 60869: Convert json_results_generator.py to output version 4 JSON.
https://bugs.webkit.org/show_bug.cgi?id=60869

Attachment 94170: Patch
https://bugs.webkit.org/attachment.cgi?id=94170&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94170&action=review

>
Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:29
7
> +	       _log.info(builder_name + " not in " + str(results_json))

Sorry, I didn't notice this before, but do we really want to log here? I prefer
avoiding spewing too much to the log since this is always run when people run
the tests. If you really think this is worthwhile, it should be _log.debug so
it's only logged with --verbose.