[webkit-reviews] review granted: [Bug 61153] WebView loses firstResponder status when entering full-screen mode. : [Attachment 94145] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 61153: WebView loses firstResponder status when entering full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=61153

Attachment 94145: Patch
https://bugs.webkit.org/attachment.cgi?id=94145&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=94145&action=review

> Source/WebKit/mac/Misc/WebNSWindowExtras.m:55
> +    if ([responder respondsToSelector:@selector(isDescendantOf:)]
> +	   && [(id)responder isDescendantOf:view])

Should keep this expression all on one line to avoid awkward placement of the
(id).

I suggest checking isKindOfClass:[NSView class] instead of specifically
checking for this selector.

I don’t think it’s really so convenient to have this as an NSWindow method. I
would suggest just making a helper function that does this. But I guess you
made it a method so you could share with WebKit2. I am not really sure that’s
the best practice way to make code you can share with WebKit1 and WebKit2.
Might be worth asking Sam about that.