[webkit-reviews] review granted: [Bug 48043] TestWebKitAPI should detect test hangs : [Attachment 94152] New, smaller patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Dmitry Lomov
<dslomov at google.com>'s request for review:
Bug 48043: TestWebKitAPI should detect test hangs
https://bugs.webkit.org/show_bug.cgi?id=48043

Attachment 94152: New, smaller patch
https://bugs.webkit.org/attachment.cgi?id=94152&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=94152&action=review

> Tools/Scripts/run-api-tests:177
> +	   eval {
> +	       local $SIG{ALRM} = sub { die "alarm\n" };
> +	       alarm $timeout;
> +	       waitpid($pid, 0);
> +	       alarm 0;
> +	       $result = $?;
> +	   };
> +	   if ($@) {
> +	       die unless $@ eq "alarm\n";
> +	       kill SIGTERM, $pid or kill SIGKILL, $pid;
> +	       $timedOut = 1;
> +	   };

It's too bad we can't share more of this code between Mac and Windows.

No need for the semicolon after the if braces.

> Tools/Scripts/run-api-tests:196
> +	   if ($@) {
> +	       die unless $@ eq "alarm\n";
> +	       $timedOut = 1;
> +	   };

No need for the semicolon after the closing brace.