[webkit-reviews] review denied: [Bug 61091] [chromium] Disable blending in compositor for WebGL layers with alpha=false : [Attachment 94136] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Kenneth Russell
<kbr at google.com>'s request for review:
Bug 61091: [chromium] Disable blending in compositor for WebGL layers with
alpha=false
https://bugs.webkit.org/show_bug.cgi?id=61091

Attachment 94136: Patch
https://bugs.webkit.org/attachment.cgi?id=94136&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94136&action=review

Code looks good but the test shouldn't output a render tree.

> LayoutTests/compositing/webgl/webgl-no-alpha.html:27
> +	   function initWebGL(canvasName, vshader, fshader, attribs,
clearColor, clearDepth)

if this is common to tests in this directory should it be moved to a helper .js
file?

>
LayoutTests/platform/chromium-gpu/compositing/webgl/webgl-no-alpha-expected.txt
:11
> +layer at (0,0) size 800x600
> +  RenderView at (0,0) size 800x600
> +layer at (0,0) size 800x472
> +  RenderBlock {HTML} at (0,0) size 800x472
> +    RenderBody {BODY} at (8,20) size 784x444
> +	 RenderBlock {DIV} at (40,0) size 200x200 [bgcolor=#00FF00]
> +	 RenderBlock (anonymous) at (0,200) size 784x244
> +	   RenderText {#text} at (0,0) size 0x0
> +	   RenderText {#text} at (0,0) size 0x0
> +layer at (28,240) size 240x200
> +  RenderHTMLCanvas {CANVAS} at (20,20) size 240x200

the layer tree is noise on this test and will just cause maintenance headaches
for gardeners.	This should be a dumpAsText(true) test