[webkit-reviews] review granted: [Bug 57543] -webkit-visual-word does not work on words separated by multiple spaces : [Attachment 93839] patch w/ layout test

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Xiaomei Ji <xji at chromium.org>'s
request for review:
Bug 57543: -webkit-visual-word does not work on words separated by multiple
spaces
https://bugs.webkit.org/show_bug.cgi?id=57543

Attachment 93839: patch w/ layout test
https://bugs.webkit.org/attachment.cgi?id=93839&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93839&action=review

>>> Source/WebCore/editing/visible_units.cpp:-1341
>>> -	     bool isLastWordBreakInBox = false;
>> 
>> Is this change necessary after you've removed the change in
nextWordBreakInBoxInsideBlockWithDifferentDirectionality?
> 
> It is not necessary for functionality correctness (isLastWordBreakInBox is
always assigned in the callee), but it is good performance wise, so, I kept it
there.

I don't think this will have any significant performance improvement.  In
practice, smaller scope/lifetime will help compiler optimization.