[webkit-reviews] review requested: [Bug 61098] Web Inspector: Provide inspector extension API to access timeline data : [Attachment 94123] Proposed patch

[bugzilla-daemon at webkit.org]

Michael Schneider <michschn at google.com> has asked  for review:
Bug 61098: Web Inspector: Provide inspector extension API to access timeline
data
https://bugs.webkit.org/show_bug.cgi?id=61098

Attachment 94123: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=94123&action=review

------- Additional Comments from Michael Schneider <michschn at google.com>
- Fixed the failing test by copying the record, enabling the timeline panel
from the test and sniffing for the records on the timeline panel.
- Incorporated review feedback.
- removed onStarted and onStopped

There are open questions:
- What is a good way to copy the record, is there a utility? I use
JSON.parse(JSON.stringify(record)) currently
- When adding a listener, the actual start of the instrumentation could be
delayed. Do we have to add a callback to EventSink.addListener which is called
as soon as the subscription is successful (seems strange, in this case I would
rather have a explicit start/stop again)? Or can we neglect that? If the async
requests wont be executed out-of-order, this is probably not an issue.