[webkit-reviews] review denied: [Bug 61132] fix render overflow computation for input type=range : [Attachment 94092] Patch

Thu May 19 13:44:19 PDT 2011

James Robinson <jamesr at chromium.org> has denied Tony Chang
<tony at chromium.org>'s request for review:
Bug 61132: fix render overflow computation for input type=range
https://bugs.webkit.org/show_bug.cgi?id=61132

Attachment 94092: Patch
https://bugs.webkit.org/attachment.cgi?id=94092&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94092&action=review

Test is (theoretically at least) flaky

> LayoutTests/fast/forms/slider-hit-testing.html:1
> +<head>

<!DOCTYPE html> plz unless this test needs quirks mode

> LayoutTests/fast/forms/slider-hit-testing.html:11
> +window.setTimeout(function() {
> +  document.getElementById("slider").style.width = "100%";
> +  changeAndCheckRangeValue();
> +}, 0);

the setTimeout is a bit odd - does the test not work if you run this code in an
onload handler? technically speaking, this setTimeout _could_ execute
immediately after parsing the end of the <script> and before the <input> is
parsed, although in practice we'll nearly always parse through the end of this
document before running timeouts.

> LayoutTests/fast/forms/slider-hit-testing.html:20
> +    var x = slider.offsetLeft + (slider.clientWidth * .75);
> +    var y = slider.offsetTop + (slider.clientHeight / 2);

could you add some comments indicating what you are trying to click on here and
what should be happening?