[webkit-reviews] review granted: [Bug 61134] Make Executables release their JIT code as soon as they become dead : [Attachment 94104] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 61134: Make Executables release their JIT code as soon as they become dead
https://bugs.webkit.org/show_bug.cgi?id=61134

Attachment 94104: Patch
https://bugs.webkit.org/attachment.cgi?id=94104&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=94104&action=review

r=me

> Source/JavaScriptCore/heap/Weak.h:133
> +	   setSlot(0);

Might as well assert that you have a finalizer here. It's not a guarantee that
you won't leak, but not having a finalizer is a guarantee that you will leak.

> Source/JavaScriptCore/runtime/Executable.cpp:56
> +    static ExecutableFinalizer* finalizer = new ExecutableFinalizer;

Please use DEFINE_STATIC_LOCAL, in accord with our style.