[webkit-reviews] review requested: [Bug 60897] [Qt] Implement toImageData() in QtWebKit Bridge : [Attachment 94090] implement toImageData() in Qt bridge

[bugzilla-daemon at webkit.org]

Andrew Wason <rectalogic at rectalogic.com> has asked  for review:
Bug 60897: [Qt] Implement toImageData() in QtWebKit Bridge
https://bugs.webkit.org/show_bug.cgi?id=60897

Attachment 94090: implement toImageData() in Qt bridge
https://bugs.webkit.org/attachment.cgi?id=94090&action=review

------- Additional Comments from Andrew Wason <rectalogic at rectalogic.com>
(In reply to comment #5)
> No'am is rewriting the bridge at the moment (see the mailing list).
> Please sync with him before updating the patch.

He said to go ahead with the patch and he will merge later.

> I don't like color conversion done like that in WebKit when you can do so
much better
> with SIMD inside Qt.

Patch is updated to do a direct copy for RGB888, ARGB32 and RGB32 and for all
other cases convertToFormat(ARGB32) and then copy from that.