[webkit-reviews] review granted: [Bug 61089] JoinTextNodesCommand is never used : [Attachment 94042] Deleted JoinTextNodesCommand

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 19 08:30:30 PDT 2011


Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 61089: JoinTextNodesCommand is never used
https://bugs.webkit.org/show_bug.cgi?id=61089

Attachment 94042: Deleted JoinTextNodesCommand
https://bugs.webkit.org/attachment.cgi?id=94042&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
It seems OK to remove this because generally speaking there’s no real value to
keeping around dead untested code. I’m not sure this offers significant
advantages over the explicit insert and delete idiom used in ApplyStyleCommand.
We can add it back if we need it later.


More information about the webkit-reviews mailing list